wasmprinter: print function bodies with code section #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2024
alexcrichton
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Sounds like a good idea to me, thanks! IIRC the motivation for doing it this way was historically wasm-tools tried to match wabt's output exactly and this is the order wabt printed things. Over time though the exact match test requirement was removed and so there's no longer any need to preserve this exact output, so I think it's reasonable to change.
For the test failures there's a few more files that need to be "blessed", and you should be able to do it with:
BLESS=1 cargo test --workspace
(or BLESS=1 cargo test -p wasm-compose for just the exact test that's failing on CI, but I suspect at least the wit-component crate may also have some differences)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasmprinter has traditionally read the code section first and then printed each function's body as soon as it reaches its entry in the function section.
For printing instructions in folded form, it's going to be inconvenient to print code before having read the whole function section (or any of the tag section), because it's necessary to have parsed these sections to know the arities of the
callandthrowinstructions.This PR reorders the wasmprinter output to print function bodies with the code section.
(PR 1/3 of adding a folding option to wasmprinter)